Responsive QR code solution using CSS Flexbox

Community feedback

• 

  MikDra1•6,980

  @MikDra1Posted 2 months ago

  If you want to get rid of overflow on the x axis here is how to do this:

  (body could be also a .container)

  body {
  overflow-x: hidden;
  }
  

  Hope you found this comment helpful 💗💗💗

  Good job and keep going 😁😊😉

  Marked as helpful

  0

  ---

  

  Natali 👻 Grimm•1,150

  @Grimm-NPosted 2 months ago

  Noted! Thank you @MikDra1

  0
• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 2 months ago

  Hi there, well done!

  These are my suggestions for improving your solution - I hope you find them helpful :)

  HTML:

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • Text should always be wrapped in a meaningful element, never in divs or landmark elements alone. Hence, the footer text needs to be wrapped in a <p>.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I would recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport. I would also add flex-direction: column and gap: 2rem, to create some space between the <main> and the <footer>. Hence, I would remove position: fixed on the footer. Also, remove the width - the body is a block element, meaning it takes up the full width by default.

  • max-width on the card should be in rem. Around 20rem will work fine.

  • Remove all widths, max-widths and heights in px.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • The footer links have very poor contrast, so I would make them a darker color.

  Marked as helpful

  0

  ---

  

  Natali 👻 Grimm•1,150

  @Grimm-NPosted 2 months ago

  @Islandstone89 Thank you for your suggestions, I really appreciate it! I will definitely review and improve this code.

  1
• 

  Vukasin-Stosic•10

  @Vukasin-StosicPosted 2 months ago

  Excellent job, you nailed it.

  0

  ---

  

  Natali 👻 Grimm•1,150

  @Grimm-NPosted 2 months ago

  @Vukasin-Stosic Thank you for your kind words!

  0