Responsive QR Code Site

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello 👋. Congratulation on successfully completing your first challenge 🎉 ! !

  I have some recommendations regarding your code that I believe will be of great interest to you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  CSS 🎨:

  • Do not use overflow: hidden on the body element, this will prevent scrolling on some devices.

  • The width: 100vw property in the body tag is not necessary. The body tag is a block element and it will take the full width of the page by default.

  • Use min-height: 100vh instead of height: 100vh. The height property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

  • There is no need to use two selectors to center the component, body, .container, you can use body and completely remove the .container tag. Then, justify-content: center; is not necessary, by using place-items: center; you will achieve centering it horizontally and vertically.

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  2

  ---

  

  Yagyesh Bobde•30

  @yagyesh-bobdePosted almost 2 years ago

  @MelvinAguilar Thank you so much for the suggestions. I have made the changes as you said.

  0