Skip to content
Submitted over 2 years ago

Responsive Qr Code Scanner

Sunday•20
@junioradeola
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Prince Roy•1,210
    @iprinceroyyPosted over 2 years ago

    that's excellent work @junioradeola. You need to focus on some key points here:-

    1. There should be one heading tag on a web page, if there is no heading element requirement, then set its font size to 0. HTML- <h1></h1> CSS- h1{ font-size: 0; }
    2. The content should be wrapped inside the main landmark to avoid accessibility issues. Like this <body><main>your content goes here......</main></body>.

    Hope it adds to your learning. Happy coding :)

    Marked as helpful
    0
    Lucas 👾•104,400
    @correlucasPosted over 2 years ago

    @iprinceroyy Hello Prince, take a look in the community guidelines, if you want to do a feedback to a person, you might open the person live site/repository and say what can be improved, you're only repeating whats been said in the report panel.

    Here's the link of the FEM Community Guidelines:

    https://medium.com/frontend-mentor/frontend-mentor-community-guidelines-44303cc38aa6

    FEM GUIDELINE PLEASE DONT: "Repeat what's been highlighted in the solution report — When a solution is submitted, we run an automated accessibility audit and HTML validation check. This report is available for all to see. Please avoid simply repeating what the report has already highlighted. Try offering additional feedback not covered in the report to help the solution author improve their project."

    I hope you don't get me bad Prince.

    0
    Prince Roy•1,210
    @iprinceroyyPosted over 2 years ago

    @correlucas okay, I thought to explain these issues in a simpler way. I will not repeat it. Thanks for the info :)

    0
    Lucas 👾•104,400
    @correlucasPosted over 2 years ago

    @iprinceroyy That's fine. When I started to give feedback I was thinking to give this same info, also because many of this things like <main> and <h1> issue I was unaware of them. But since there's the report panel to point this errors, the user can only check by themselves. I hope you don't get bothered by what I've said Prince.

    0
    Prince Roy•1,210
    @iprinceroyyPosted over 2 years ago

    @correlucas yeah! whatever you said is correct but now I'm feeling sad as I was not aware of fem community guidelines, I've violated the guidelines. I'm worried about the profile ban :(

    0
    Lucas 👾•104,400
    @correlucasPosted over 2 years ago

    @iprinceroyy I don't think will happen, this is fine. Just keep giving good feedback like you're doing, open the repository/live site and give your opinion what they could do to improve and etc. Since you've done a lots of challenges you've a lots of knowledge to share Prince. Don't worry.

    0
    Prince Roy•1,210
    @iprinceroyyPosted over 2 years ago

    @correlucas You're great, man. I appreciate the way you are mentoring folks.

    1
    Sunday•20
    @junioradeolaPosted over 2 years ago

    @iprinceroyy thanks so much for your observation ill take note and make adjustments accordingly.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord