
Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
PARAGRAPHS ⚠️:
- This solution consists incorrect usage of
<p>
so it can cause severe accessibility errors due to incorrect usage of paragraph<p>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- In this solution there's
<p>
element which is this<p>Improve your...</p>
, you can preferably use<h1>
instead of<p>
. Remember<h1>
provides an important navigation point for users of assistive technologies so we want to use it wisely
- So we want to add a level-one heading to improve accessibility
- Example:
<h1>Improve your front-end skills by building projects</h1>
- If you have any questions or need further clarification, and feel free to reach out to me.
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
Remove
margins
from.wrapper
as it will not dynamically center the card. -
To properly center the card
-
USING FLEXBOX
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
-
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
instead of p to improve accessibility. -
<h1>Improve you frontend skills by building projects</h1>
-
Use
Semantics
for the proper design of your code.
<body> <main>...</main> <footer>...</footer> wrap up `.attribtution(challenge by....)` div inside your footer. </body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Don't use
multiple styling methods
.Removestyle.css
.
I hope you find this helpful.
Happy coding😄
Marked as helpful0 -
- @sjarvisPosted over 1 year ago
Thanks for all the feedback! I've updated the project solution based on feedback suggestions. --SWJ
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord