Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR Code page with CSS

@hunchohoudini007

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I feel like like there are "cleaner" ways I could have written the css. I would appreciate any input I get.

Community feedback

David 60

@dvd41esp

Posted

Hi there buddy.

Everytime you use margin and/or paddings:

If they are the same everywhere, just type "margin: 10px;" or "padding: 10px;"

If they are the same in "x" axis and in "y" axis: "margin: 10px 40px;". 10px for "y" axis, 40px for "x".

Flex-box would be a cleaner way to display this one challenge. But still, nice solution tho!

Marked as helpful

1

@hunchohoudini007

Posted

@dvd41esp I actually tried doing that but I was trying to "see" everything so I would easily notice any fault if any cropped up.

1
Adeola Ganiu 1,320

@Deolabest

Posted

Hey @hunchohoudini007, Congratulations on completing this challenge!

Here is my feedback:

  • I'll suggest you move the attribution below the container.

  • To center a container at the center of the page, this is enough:

body {
    flex-direction: column;
    align-items: center;
    justify-content: center;
    display: flex;
}
  • A simple padding: 3mm; would have been okay instead of this:

    padding-top: 3mm; padding-left: 3mm; padding-bottom: 3mm; padding-right: 3mm;

Keep doing a good job!

Marked as helpful

1

@hunchohoudini007

Posted

@Deolabest I was honestly looking for the right attributes to center the container properly but the right attributes skipped my mind that's why it looks different on different screens.

1

@ysnitko

Posted

nice

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord