Responsive QR code Page using HTML and CSS
Design comparison
Solution retrospective
Please check out my first challenge and let me know what I need to improve on
Community feedback
- @hyrongennikePosted about 2 years ago
Hi @solomonade1,
Nice job on completing you first challenge
Just check the report above and fix those issue, it's most likely because you didn't use a main tag you can replace the .modal div with a main tag and instead of a h2 use a h1 all pages need a h1 tag.
You can read the below article on semantic HTML.
Hope this is helpful
Marked as helpful1 - @101AminePosted about 2 years ago
π¨βπ» Hello @solomonade1, Congratulations on completing this challenge!
-
Good work, you just need to decrease the fonts a little bit and add more padding to make it look better, In the p tag
p { padding-block: 1rem; }
-
Use relative units as rem or em instead of px to improve your performance, because a pixel is not responsive and that's why it's better to use REM
Hope that was helpful for you, have a good day
0@solomonade1Posted about 2 years ago@101Amine thank you for the feedback. I will work on it.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord