Responsive QR-code page using Flex

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 23 days ago

  Hello, good job!

  A few suggestions I hope you find helpful :)

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Wrap the card in a <main>.

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Move font-family from * to the body.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • Remove the width in px on the card. We rarely want to give a component a fixed size, as we want it to grow and shrink according to the screen size.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • On the image, add height: auto, display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • Using descendant selectors like .text-content h2 increase specificity, which makes it harder to override. Instead, it's recommended to give elements a class, and use that as the selector.

  Marked as helpful

  0
• 

  P

  cookie-monster01•110

  @cookie-monster01Posted 23 days ago

  I have recently started learning html and css. Hence, I do not feel comfortable writing any feedback, but I would say that for padding and margins its better to use em and for font-size its better to use rem as these are responsive units and px is hard-coded and not responsive.

  1