Responsive QR Code page - HTML, CSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace the section tag <section> with the main tag, <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .card_white on the page using flexbox, add min-height: 100vh and justify-content: center to the body.

  To center .card_white on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  Give .card-white a fixed max-width value and the same padding value for all the sides. max-width: 320px padding:16px

  Give the img a max-width of 100%.

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Jhef•140

  @imjheefPosted almost 2 years ago

  @Hassiai Hi! You were helpfull, thank you for the video as well♥

  0
• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The heading order is important in the html structure so try to always start your headings and/or titles with an <h1> tag and then you can decrease by one if you need to use more headings in your html code.

  CSS🎨:

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here

  I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

  Happy <coding /> 😎!

  Marked as helpful

  1

  ---

  

  Jhef•140

  @imjheefPosted almost 2 years ago

  @frank-itachi. Thank you! I really appreciate the feedback.

  0