Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I think i did well with my html
What challenges did you encounter, and how did you overcome them?I had challenges with the styling and it took me a little while before i got it right. I had to watch tutorials to get it right
What specific areas of your project would you like help with?I need help with my styling
Community feedback
- @mkborisPosted 8 months ago
Hi amnesia2k, great job, here are some suggestions
- All content should be wrapped within landmarks. Wrap a
main
tag around the container and afooter
for the attribution. font-size
should be in rem not px.- You don't really need media queries for this challenge but if have to, it must be defined in rem or em not px.
- Consider using a modern CSS reset at the start of the styles in every project. Like this one modern css reset.
0 - All content should be wrapped within landmarks. Wrap a
- @al-dellPosted 8 months ago
Hi there. Good work on completing the challenge!
I do have a couple of suggestions to keep in mind:
- Adding text to the alt attribute of the
<img>
element would make the content more accessible and can provide information for the image if the user can't see it. - Consider using
margin-left
andmargin-right
in your CSS to control the layout better rather than using the<br>
element.
Adjust the font sizes for the header. Otherwise, keep it up!
0 - Adding text to the alt attribute of the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord