Responsive QR Code page

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @guidoaguiar 👋, good job on completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Your solution must contain a title tag with the name of the challenge and an icon.

  <title>Frontend Mentor | QR code component</title>
  <link rel="icon" type="image/png" sizes="32x32" href="./favicon-32x32.png" />
  

  • Instead of using <section> to wrap the whole content, use <main> tag.

  • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information or remove it from your code if you don't use it.

  • To make alternative texts more useful, add descriptive text to the alt attribute of the QR image to explain what the QR image does.

  • Use an h1 tag for your solution. The <h1> element is the main heading on a webpage, also, there should only be one <h1> tag per page.

  <h1>Improve your front-end skills by building projects</h1>
  

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  2

  ---

  

  Guido Aguiar•20

  @guidoaguiarPosted about 2 years ago

  @MelvinAguilar Thank you, Melvin, I reviewed your tips and made changes to the code, I'll keep this feedback in mind, it was constructive to see what I have missed.

  1

  

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  @guidoaguiar Hi, please remove aria-hidden="true" from the image tag, this image is not a decorative image, this image is the main content of the component, You can read more about alternative text here.

  Here is the solution for this challenge from an accessibility expert: Simple single-card challenge built with scss (Grace-snow)

  Marked as helpful

  0
• 

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  Hi Guido Aguiar, how are you?

  Welcome to the front-end mentor community!

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Guido Aguiar•20

  @guidoaguiarPosted about 2 years ago

  @AdrianoEscarabote Thank you, Adriano, the feedback was very constructive and the alt text purpose is very important, thanks for that. I made some changes and should be good now.

  1

  

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  @guidoaguiar happy coding!!

  0