@elaineleung
Posted
Hi AyeniOlaoluwa, great work here! About your question, you already have done a lot to make it responsive, including using max-width: 100
with width: 400px
and even using clamp()
(which isn't an easy for many people)! One thing to suggest here: you can combine max-width: 100
with width: 400px
as one declaration, like this: width: min(100%, 400px)
. Anyway, I really think you've done everything to make it responsive, and that's a great job 😊
Two other things you can consider/try:
-
I notice you're not using the font face listed in this design; you can try using Google Fonts to grab the link. I think once you change the font family, your design will look really close to the original.
-
I see that you're using custom properties, great job! The only thing is, you should have them at the top whenever possible. I also see that you have a star selector rule, which is a good start to using reset/normalize rules. You can try adding more rules, especially the one for images since you'll most likely be working a lot with them in these projects.
That's all for now, great job once again, and keep going!
Marked as helpful
@ayeniOlaloluwa
Posted
@elaineleung Thanks for your comment. I really appreciate and I'll try working on your suggestions