@JYLN
Posted
I like your use of min-height
and flexbox for centering content. It was a trick I learned way too late into my learning, and it's been a life-saver with centering content. I also have used grid with the same min-height technique and it's great!
The only suggestions I have is:
- Be careful to constrain your heights on your elements. Your card height is locked in at a px specific height, especially since it's not
min-height
. It's a habit I have as well. Ultimately, I think it's best that the flow of the layout justifies the heights of the overlying elements. - Some left and right padding on the text of the card may help it not seem so cramped within the card
Overall, great job! Keep up the good work
Marked as helpful
@vanshraheja75
Posted
@JYLN Thanks for the tips !