Skip to content
Submitted 4 months ago

Responsive QR code page

Vansh Raheja•60
@vanshraheja75
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

it was an easy one

What challenges did you encounter, and how did you overcome them?

no challenges

What specific areas of your project would you like help with?

any suggestion acceppted

Community feedback

  • Jaylen Baxter•300
    @JYLNPosted 4 months ago

    I like your use of min-height and flexbox for centering content. It was a trick I learned way too late into my learning, and it's been a life-saver with centering content. I also have used grid with the same min-height technique and it's great!

    The only suggestions I have is:

    1. Be careful to constrain your heights on your elements. Your card height is locked in at a px specific height, especially since it's not min-height. It's a habit I have as well. Ultimately, I think it's best that the flow of the layout justifies the heights of the overlying elements.
    2. Some left and right padding on the text of the card may help it not seem so cramped within the card

    Overall, great job! Keep up the good work

    Marked as helpful
    0
    Vansh Raheja•60
    @vanshraheja75Posted 4 months ago

    @JYLN Thanks for the tips !

    0
  • Hope•10
    @0xH0pePosted 4 months ago

    pretty cool

    0
    Vansh Raheja•60
    @vanshraheja75Posted 4 months ago

    @0xH0pe thanks

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord