Responsive QR code

Community feedback

• 

  Bishal Singh Deo🎮•1,440

  @Bishalsnghd07Posted 9 months ago

  Hi, kelvinbam👋

  Congrats for completing this challenge🎉

  But, I like your layout, it looks unique to me😍

  Some, semantic HTML and CSS foundation issues in your code, a few adjustments needed:

  1)Always follow the heading levels, never use h4 directly without using h1, heading levels are like this👉h1, h2, h3, h4, h5 & h6. <h1> is the most important and <h6> will be least important. And h1 should be used only once in single project and it will be the main header of your component. By doing this your semantic HTML will improved and code quality too.

  2)Add align-items in your body to center your main layout vertically. You used justify-content in body you did well job for this. Just will recommend to add align-items too to make your layout one step closer to responsiveness.

  3)Add min-height in body of your web page to prevent your layout from breaking, using min-height in body is basic CSS approach and best practice.

  By doing this adjustment in your project, your semantic ui will improved and code quality also.

  Hope, this tips will help you in further projects too.

  Good luck and happy coding❤️

  Marked as helpful

  0

  ---

  

  Kelvin Mai'Angwa•250

  @kelvinbamPosted 9 months ago

  Thank you very much this feedback means a lot for me I'll definitely take note of all necessary adjustment to improve @Bishalsnghd07

  0