Design comparison
SolutionDesign
Community feedback
- @frank-itachiPosted over 1 year ago
Hello there 👋. Congratulation for completing the challenge👍!
I have some suggestions about your code that might interest you.
HTML 📄:
- Put the
<div class="attribution">
content out of the<main>
and wrap it inside the<footer>
tag. - The heading order is important in the html structure so try to always start your headings and/or titles with an
<h1>
tag and then you can increase by one if you need to use more heading in your html code. So replace the<p class="bold">
by the<h1>
tag - Change the image's source(src) attribute by
src="image-qr-code.png
. That's because the image resides on the same level as the index.html file. - Make sure that the
<img>
elements in your HTML code has an alternate (descriptive) short text. The reason for this is that screen readers can’t translate images into text. So to fix this you can do the following<img src=”…” alt=”short text” >
I hope you find it useful! 😄 Above all, you did a good job!
Happy
<coding />
😎!Marked as helpful0 - Put the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord