Submitted 7 months ago

Responsive QR code

Mahmoud ELattar•20

@DevMahmoudElattar

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

am proud of being part of this community actually more than coding in itself, in this challenge i used pure HTML, CSS which actually took me a lot of time as i mainly use tailwind , Vite , react and next in building websites , but it's a good reminder for how to use pure css anyway

What challenges did you encounter, and how did you overcome them?

image & object contain, l always forget about them and need to google them

What specific areas of your project would you like help with?

Accessibility, have feeling am not good with it

Community feedback

Daniel 🛸•44,310
@danielmrz-devPosted 7 months ago
Hello there!

Congrats on completing the challenge! ✅

Your solution is really impressive!

I've got a couple of ideas (about how to use HTML better) that could make it even stronger:

📌 First: Think about using <main> to wrap your main content instead of <section>.

Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

📌 Second: Consider employing <h1> to <h6> tags for headings rather than using <p>.

The <p> tag is primarily intended for paragraphs. When it comes to headings, HTML offers us a range of heading tags: from <h1> to <h6>.

Here's a quick guide on how to use them:

The <h1> to <h6> tags are used to define HTML headings.

<h1> is for the most important heading.

<h6> is for the least important heading.

Stick to just one <h1> per page – it should be the main title for the whole page.

And don't skip heading levels – start with <h1>, then use <h2>, and so on.

It's more than just text size — it's about structuring your content effectively.

These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.

Hope that's helpful!

Keep up the great work!
Marked as helpful
1
Mahmoud ELattar•20
@DevMahmoudElattarPosted 7 months ago
@danielmrz-dev thanks i really appreciate your comment it is very helpful
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord