pauzuffinettiā¢ 90
@pauzuffinetti
Posted
Thank you! I thought aplying flexbox to the body element wasn't considered a good practice, but i'll try it out!
0
Design comparison
Solution retrospective
What are you most proud of, and what would you do differently next time?
Hi! I'm trying to become a great front end developer, discovering this page makes me so excited! Any constructive criticism is always welcome!
What challenges did you encounter, and how did you overcome them?
Making the QR be in the middle of the page
What specific areas of your project would you like help with?
Honestly, any errors you see or anything that you've done differently, just let me know. I love learning and i welcome advice from those who are more experienced.
Community feedback
Birushaā¢ 60
@BirushaNdegeya
Posted
Hello there š š @pauzuffinetti,
Your project looks great, but I have some suggestions to improve its accessibility. Consider using <main role="main"></main> instead of <div></div>, and you don't need to use these properties to center your container:
.bigcontainer {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
}
Instead, it is a good practice to do:
body {
min-height: 100vh;
display: flex;
justify-content: center;
align-items: center;
}
I hope this answers some of your questions. If you have any other questions, feel free to ask me.
š š š Happy coding! š š š
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord