Responsive QR code first Challenge

Community feedback

• 

  Oscar Bocanegra•235

  @obocanegra-devPosted over 1 year ago

  Hello Sansa! 👋

  Congratulations on your progress on this project! I have some suggestions to further enhance your design:

  Instead of using padding: 5%; to center the container, I recommend applying the following properties to the body selector in your CSS file: display: flex; flex-direction: column; justify-content: center; align-items: center; min-height: 100vh;. This will effectively center the container both vertically and horizontally. Once you make these adjustments, you can remove the padding property.

  Additionally, I suggest using relative units, such as rem or em, for font sizes instead of pixels. This allows for better scalability and ensures that your text adapts well to different devices and screen sizes.

  For images that are not purely decorative, like the QR code, it's beneficial to provide a descriptive alt attribute. For example, you could use "QR code to Frontend Mentor website". This provides valuable context to users who rely on assistive technologies, enhancing the accessibility of your site.

  You're doing a fantastic job! Keep up the great work, and don't hesitate to ask if you have any questions or need further assistance. Good luck with your future endeavors! 🚀✨

  Best regards, Oscar

  Marked as helpful

  1