Responsive QR Code

Community feedback

• 

  Hana•960

  @Hanka8Posted over 2 years ago

  Hi Osama, nice job!

  When you use "%" on width, the card will shrink on smaller screens. Instead, you can use "rem" - then the cards width will remain the same even on smaller screens, so you wont need any special media queries for responsiveness.

  Other suggestions:

  • use "rem" istead of "px" for "font-size", so the users can change it in their browsers - its considered a better habit for accesibility;

  • its better to use semantic elements instead of non-semantic, so you should use <main> instead of <div>;

  • headings should start at <h1> level, also the document should contain at least one level-one heading, so you should use <h1> instead of <h2>;

  Keep up the good work! ☺

  Marked as helpful

  1

  ---

  

  Osama Ahmed•50

  @Osama472Posted over 2 years ago

  @Hanka8 Thank you so much for the suggestion it will help me a lot and also thank you for your feedback. :)

  0

  

  Hana•960

  @Hanka8Posted over 2 years ago

  @Osama472 You are welcome ☺

  0