Mennatallah Hesham• 1,490
@Mennatallah-Hisham
Posted
Hi Aman kwafrifa,
Congratulations on completing your first challenge👏
You did great 👍
Here are some suggestions to improve your code:
Semantic HTML
- wrap your content in <main>,this element represents the dominant content of the <body>
- wrap your card in <article>
<main>
<article>
</article>
</main>
<footer>
</footer>
ALT
- images should have descriptive alt text, which is important for SEO and screen reader users,alt="QR code linking to Frontend Mentor challenges"
INTERNAL CSS
- it is better to use external css over internal css as your project grows you may suffer from some of internal css disadvantages such as:
- Repetition in HTML files.
- Increased file size.
- Reduced code reusability.
- Limited style management across pages.
SEO
- you can add meta description for better SEO, it provides a brief summary of a web page
<meta name="description" content="..........."/>
here are some helpful articles:
Hope you find this helpful, Happy Coding
Marked as helpful
0
