Responsive QR Code Component using Semantic HTML and CSS

Community feedback

• 

  KapteynUniverse•1,480

  @KapteynUniversePosted 13 days ago

  Hey, nice job. Ok, from top to bottom :D

  For the challenges on here, it is probably not needed but using colors, font-weights, sizes etc. as variables would be a good practice. Like:

  :root {
    /* Primary */
    --dark-cyan: hsl(158, 36%, 37%);
    --cream: hsl(30, 38%, 92%);
    /* Neutral */
    --very-dark-blue: hsl(212, 21%, 14%);
    --grayish-blue: hsl(228, 12%, 48%);
    --white: hsl(0, 0%, 100%);
    --fs-p: .875rem;
    --fw-500: 500;
    --fw-montserrat-700: 700;
  }
  

  and then you can use them for styling like background-color: var(--cream); . These things may change in a real project, so when it does all you have to do is change them from the root instead of searching in the whole css file/s. --cream is a custom name btw, you can name it anything you want. But for readability giving it a meaningful name would be beter.

  Using a modern css reset for the future challenges will help you.

  You can use flex or grid for centering.

  body {
  display: flex;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
  }
  

  or

  body {
  display: grid;
  place-content: center;
  min-height: 100vh;
  }
  

  Avoid using hard coded values, like width: 275px; use max-width: 275px; instead, max-width: 20rem; would be even better. Em/rem units are better for responsiveness. I recommend you to check Kevin Powell's this video for better understanding.

  Imgs need to have meaningful alt text, except for the decorative imgs. You already wrote something but i think it needs a little bit more context. Like "QR Code - Scan to access Frontendmentor.io" It might confuse the screen reader users, like access to what?

  This component is for to use in a web page and every page should only have one h1(mostly). This is a simple product card, it would never be used to serve the main heading on a page, using a h2 for h1 would be better. But on the future challenges doing this will give you a warning on the HTML report when you submit a solution. If it bugs you, you can create a h1 with some text and make it for screen reader only.

  Marked as helpful

  1

  ---

  

  A_boo_bae•80

  @UnifiesPosted 12 days ago

  @KapteynUniverse This is a great guide, I learnt a lot just reading through. I'll implement these changes in optimizing my code, thank you so much for the feedback!

  1