Responsive QR code component using HTML & CSS

Community feedback

• 

  Vincent Daniel•410

  @davinceeyPosted about 2 years ago

  Hello Mohit. Congratulations on your first project! This is apt and great on the whole. Just some little tips for improvement:

  1. You might want to replace the p tag used in the first write-up, with a h1 tag, so that your <main> tag, has a level-one heading.

  2. You might as well, want to use more of relative units such as the em and rem in applying to padding, margins, widths and font-sizes. This would help to increase the responsiveness of your layout.

  You did very well. Keep up!

  Hope this helps you. Happy Coding!👊

  Marked as helpful

  1

  ---

  

  Mohit•50

  @paryanimohit1Posted about 2 years ago

  @davinceey Thank you for taking the time to review my code and providing feedback regarding the same.

  I implemented both the points mentioned by you in my repo. Site hosted here.

  I've used em with the text elements as I have added their font-size and for the rest, I've used rem. Maybe you can spare a minute or two to review it and suggest if I have done something wrong, that will be very helpful. I'll be looking into this more for a better understanding.

  Again, Thank you for your suggestion, will keep this in mind in the future. Happy coding!

  1

  

  Vincent Daniel•410

  @davinceeyPosted about 2 years ago

  @paryanimohit1 I'm glad to help. It's very much fine now. Happy Coding with your other projects!

  1
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Mohit, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  Your component is perfect, but is not responsive yet, this is due the fixed width you've applied to the container.

  Look both width and max-width the main difference between these properties is that the first(width) is fixed and the second(max-width) is flexible, for example, a component with width: 320px will not grow or shrink because the size will be ever the same, but a container with max-width: 320px or min-width: 320px can grow or contract depending of the property you've set for the container. So if you want a responsive block element, never use width choose or min-width or max-width.

  Note that there's no need to use height here, because since you set a height for an element, this means that this element will grow until a certain point and after that the inner content (as texts or images) will start to pop out the element due its fixed height, so isn't necessary to set the height the container height comes from the elements, its paddings and height.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Mohit•50

  @paryanimohit1Posted about 2 years ago

  @correlucas Thank you for taking the time to review my code and providing feedback regarding the same.

  I've used height: 100vh because the body should take the full height. Although, I've changed it to min-height now in my repo. Also, I replace width with max-width for the image but it didn't seem to make a difference when I tried lowering the width of the screen. Hosted here.

  Maybe if you can spare a minute or two to check if I am doing something wrong, that would be really helpful. I'll look into it a bit more to get a better understanding of what's exactly happening.

  Again, Thank you for your suggestion, will keep this in mind for future, and Happy coding!

  1

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @paryanimohit1 I think you did all fine Mohit, only one more thing to change is the <span> with <p> thats a better tag for that paragraph. The rest is perfect. Congrats!

  Marked as helpful

  1

  

  Mohit•50

  @paryanimohit1Posted about 2 years ago

  @correlucas Makes sense, I will do that change. Thank you for pointing this out.

  1