Design comparison
Solution retrospective
Is there any problem to be fixed?
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello There👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports due to
non-semanticmarkup, which lack landmark for a webpage
- So fix it by replacing the
<div class="container">element with the semantic element<main>in yourindex.htmlfile to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>
- They convey the structure of your page. For example, the
<main>element should include all content directly related to the page's main idea, so there should only be one per page
HEADINGS ⚠️:
- And, this solution has also generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1element identifying and describing the main content of the page.
- An
h1heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-onlyclass to hide it from visual users (it will be useful for visually impaired users)
ESSENTIALS ♻️:
- And, This solution has also generated accessibility error reports due to lack of
langattribute inside ofhtmlelement
<html>element must have a lang attribute with valid value, so fix it by updating like this<html lang="en">
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1 - @tobezhanabiPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage
So fix it by replacing the element <div class="container"> the with semantic element <main> in your index.html file to improve accessibility and organization of your page.
What is landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>.
They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page
HEADINGS ⚠️:
This solution also generated accessibility error report due to lack of level-one heading <h1> Every site must want at least one h1 element identifying and describing the main content of the page.
An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users) I hope you find it helpful ! 😄 Above all, the solution you submitted is great
Happy coding!
1@0xabdulkhaliqPosted over 1 year ago@tobezhanabi
- Please don't copy paste another comment to get points.
- Avoid Plagiarism, this act is opposing community guidelines of frontend mentor
Thanks.
2
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord