Responsive QR Code Component using HTML & CSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="main-content"> with the main tag and <h3> with <h1> to make the content or page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  There is no need to give the body a background-image and to style .main-content. Give the body the background-color you gave to .main-content to the body which is hsl(212, 45%, 89%);

  To center .qr-component on the page using flexbox or grid instead of margin:

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: add min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  2

  ---

  

  Kieran Price•80

  @kieranpdevPosted over 1 year ago

  @Hassiai

  Thank you this was really helpful feedback and I have implement the changes which you suggested to the HTML and CSS files.

  0