@NehalSahu8055
Posted
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
Remove margin from
.containeras it will not dynamically center the card. -
To properly center the card
-
USING FLEXBOX
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
-
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one headinginstead of h2 to improve accessibility. -
<h1>Improve you frontend skills by building projects</h1> -
Use
Semanticsfor the proper design of your code.
<body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribtution` div inside your footer.
</body>
-
For
non-decorative imagesgive meaningful and descriptive alt likealt= "QR code to frontend mentor website". -
Use
responsive units(rem, em, %)from next project. Explore respective use cases on google. -
Replace
widthwithmax-widthto make your card more responsive.
link.
I hope you find this helpful.
Happy coding😄
