Submitted about 2 years ago
Responsive qr code component using flexbox in css
@hebrohim
Design comparison
SolutionDesign
Solution retrospective
At first ,it was very difficult for me to use flexbox for a parent tag and its child tag, I had to visit w3schools to get better understanding of how it works
Community feedback
- @kostyafarberPosted about 2 years ago
Hi there!
First of all well done! It looks great. Just a few suggestions
- Try to remove any code that isn't being used anymore. It makes your code more readable. (e.g,
/* background-color: red; */on line 41 in your CSS file. - I would suggest setting your colours in variables using
:root, and then applying those to your elements. If you were to ever change them you would only have to do it in one place! - Try to add
alttags for your images. It improves accessibility. - Finally try using
paddingon your divs to control how the text breaks when divs are resized. Addingbrmay not be the best approach here! Just a few tips, hope it was helpful and keep on coding!
Marked as helpful0@hebrohimPosted about 2 years ago@kostyafarber thanks so much for your comment. I will apply your recommendations .
1@kostyafarberPosted about 2 years ago@hebrohim No worries! If you found my response helpful can you please mark it as helpful 😁.
Happy coding!
0 - Try to remove any code that isn't being used anymore. It makes your code more readable. (e.g,
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord