Design comparison
Solution retrospective
Does it matter if i don't use the provided screen breakpoint? I used flexbox which makes it quite responsive without the break point
Community feedback
- @correlucasPosted about 2 years ago
πΎHello Joshua, congratulations on your first solution!π Welcome to the Frontend Mentor Coding Community!
Nice code and nice solution! You did a good job here putting everything together. Iβve some suggestions for you:
The HTML structure is fine and works, and you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary
<div>
. For this solution you wrap everything inside a single block of content using<div>
or<main>
(better option for accessibility) and put inside the whole content<img>
/<h1>
and<p>
.<body> <main> <img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>
βοΈ I hope this helps you and happy coding!
Marked as helpful0 - @jhellardPosted about 2 years ago
Hey Joshua! For something with a simple layout like the QR code if you find there is no need for the breakpoint I'd just go without it as long as the content is displayed properly at all screen sizes.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord