Responsive QR Code Component using Flexbox and CSS Grid

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 5 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution is really impressive!

  I've got a couple of ideas (about how to use HTML better) that could make it even stronger:

  📌 First: Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  📌 Second: Consider using <h1> for your main title instead of <h2>.

  It's more than just text size — it's about structuring your content effectively:

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> is for the most important heading.
  • <h6> is for the least important heading.
  • Stick to just one <h1> per page – it should be the main title for the whole page.
  • And don't skip heading levels – start with <h1>, then use <h2>, and so on.

  These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.

  Hope that's helpful!

  Keep up the great work!

  0
• 

  Guerinik Abderrahmane•480

  @AbderrahmaneGuerinikPosted 5 months ago

  Hey, you did well in general but there is some details that you can improve :

  • add margin bottom and border radius to the image

  img {
     border-radius: 20px;
     margin-bottom: 1.5rem;  
    }
  

  For responsivity of the container div you can do this :

  .attribution {
    width: min(95%, 350px)
    }
  

  0