Skip to content
Submitted about 2 years ago

Responsive QR code component using flexbox

Ubaldo•460
@uvdevelop26
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi Beto, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

    1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    2.Replace the <h2> heading with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use ever the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

    3.Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Ubaldo•460
    @uvdevelop26Posted about 2 years ago

    @correlucas thanks i'll make those changes as well

    0
  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi Beth, how are you?

    Welcome to the front-end mentor community.

    I really liked the result of your project, but I have some tips that I think you will like:

    1- All page content should be contained by landmarks click here

    2- Page should contain a level-one heading, you could have changed h2 to h1 click here

    3- Document should have one main landmark, you could have put all the content inside the main tag click here

    I noticed that the page had a scrollbar, to fix this we can do the following:

    I removed this code:

    .container { /* height: 100vh; */ }

    I added:

    body {
    display: flex;
    align-items: center;
    justify-content: center;
    flex-direction: column;
    min height: 100vh;
}

    Or you can just move the div.attribution inside the container.

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
    Ubaldo•460
    @uvdevelop26Posted about 2 years ago

    @AdrianoEscarabote Hi Adriano, thank you.. front-end mentor is amazing... and tank you for your tips, i will definitely will follow it so i get better fastly

    0
    Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    @uvdevelop26 no problem, keep coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord