Responsive QR code component using CSS properties and flexbox

Community feedback

• 

  Radek•490

  @RadexmanPosted about 2 years ago

  Hi there mate! Good job on that project! If you don’t mind, I will provide you with some feedback :)

  So I checked your code and it appears that you used <h3> and skipped the <h1> tag. This is considered a mistake because when using headings we want to stick to the so - called hierarchy. You probably did it because the font size was correct but you can just change it in css in no time. We typically want to start from h1 because it should be a main title on our page and move our way to h6. Here is some good resource on that topic:

  https://www.contentkingapp.com/academy/headings/

  Aside from that the code looks good, you have a good naming convention for classes. Very readable and self-explanatory.

  Overall amazing work on that project! I hope I was a little bit helpful for you. Good luck on next projects and happy coding!

  Marked as helpful

  1

  ---

  

  Aziz Prabowo•220

  @azizp128Posted about 2 years ago

  @Radexman Thanks for the feedback!! I just changed the code, now there are no more headings. I changed that heading to <div> so I can more easily adjust the font size.

  1