Responsive QR code component using CSS Flexbox

Community feedback

• 

  Pradeep Saini•990

  @pradeeps4iniPosted over 2 years ago

  Hi, jaheem.

  You implemented the design pretty well.

  I would like to suggest some changes, that will make the code better.

  • Use semantic markup. For the card component you can use <main>, tag since card is the only main content on the page.

  • In your CSS, you're repeating the styling for .card-component in both the desktop and mobile mode. When you wrote the style outside media query, it will cascade and will be applied in the media query as well. You should only write the properties you want to change. Don't rewrite the properties, you're not changing.

  Marked as helpful

  1
• 

  Remtaine•360

  @remtainePosted over 2 years ago

  It looks really good! It's pretty similar to the desktop and mobile design images so I don't think there's a problem. I suggest you add a shadow next time so it looks more like the design

  1

  ---

  

  P

  Jaheem Prevost•80

  @jaheemprevostPosted over 2 years ago

  @remtaine I didn't even notice there was a shadow effect! Thanks!

  0