Responsive QR code component using CSS flexbox

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Hamdi, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • I saw that you've used px and rem, but I think is better you use only rem to have your code with a standard. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Hamdi•170

  @justgo97Posted about 2 years ago

  Hi @correlucas Thanks for your feedback! I have pushed an update that covers all the points you mentioned, Though I'm not sure if I followed the last recommendation correctly, and If I should completely remove any occurrences of px like in margins and other places.

  0

  

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  @justgo97 If you're using rem its better to use everywhere to make easier to work with your code.

  To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  Marked as helpful

  0

  

  Hamdi•170

  @justgo97Posted about 2 years ago

  @correlucas Yes I'm using vscode, I didn't know such an extension exist, I will be using it from now on, Thanks a lot!

  1