Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR code component using css flex

@Code-Me-Well

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


During the development of this project, I encountered two significant challenges related to responsive design. The first involved ensuring images within the pages adapt seamlessly to different screen sizes without compromising their visual integrity. The second challenge arose from the need to utilize different font weights for distinct sections while maintaining a consistent font family.

Any feedback is welcome

Community feedback

Kimo Spark 2,190

@kimodev1990

Posted

  • For maintaining images sizes with different layout dimensions : By wrapping the images inside a DIV and giving width:100% for image and for the DIV we use the clamp ( ) method to change the size according to viewport dimensions and suiting different devices' layouts . Other than that, Keep going on & nice work.

Marked as helpful

1
Daniel 🛸 44,230

@danielmrz-dev

Posted

Hello @Code-Me-Well!

Your project looks great!

I have a few suggestions for you to improve it:

1 - About font-weight: Instead of using bold, bolder you can give it number values. In the style-guide file, you can check what are the recommended font-weights for the project. I always import all the available weights from Google Fonts and test them until I get the closest result from the original design.

Also, I noticed that you used a h3 for the title. Since that's the main text on the screen and every page should have a h1, you can replace that h3 with a h1. That will help you with the font-weight problem too.

2 - You used 2 different divs for the main content. Unless you have a specific reason to do that, that's not necessary. You can use only one tag and since it's the main content, for semantic purposes, it should be a main tag.

Your project already looks very good, but those suggestions can make it more semantic and also optimize your code.

I hope it helps! 😊

Marked as helpful

0
Ah-med007 40

@Ah-med007

Posted

I don't think div have semantic meaning, I think the img should be in a figure tag then placed together with the paragraph inside a main tag. I also don't think you successful imported/linked the outfit font to your stylesheet

Good work!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord