Submitted over 1 year ago
Responsive QR code component using CSS Flex
@Mahmoudamin11
Design comparison
SolutionDesign
Solution retrospective
Any feedback please to reduce the unnecessary code :)
Community feedback
- @fernandolapazPosted over 1 year ago
Hi ππ», some of this may interest you:
- The image is not decorative and therefore the
alt
attribute should have at least a short description, like 'QR code to visit Frontend Mentor'.
- It is better to use
min-height: 100vh
for the body as usingheight
causes the page to be cut off in viewports with small height (such as mobile landscape orientation).
- Regarding what you mention about reducing unnecessary code, the only thing I see is that you could remove
font-weight: bold
from the <h2>.
I hope itβs useful : )
Regards,
Marked as helpful0@Mahmoudamin11Posted over 1 year ago@fernandolapaz this the most useful comment i have ever recieved thank you : )
1 - The image is not decorative and therefore the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord