Responsive qr code component using css

Community feedback

• 

  P

  Øystein Håberg•10,330

  @Islandstone89Posted about 1 month ago

  Hey, well done!

  Here are a few tips to make your solution even better:

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Move font-family from * to body.

  • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • max-width on the card should be in rem. Around 20rem will work fine.

  • font-size on .attribution must also be in rem.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  0
• 

  Rattanon Rattanachakorn•50

  @PotarattanonPosted about 1 month ago

  Does the solution include semantic HTML? Is it accessible, and what improvements could be made? Does the layout look good on a range of screen sizes? Is the code well-structured, readable, and reusable? Does the solution differ considerably from the design?

  0