Responsive QR Code Component Using Bootstrap

Community feedback

• 

  Shivraj K•400

  @Shivraj-K09Posted over 1 year ago

  • Nesting: The number of layers needed for your HTML structure will depend on the complexity of your layout and the design requirements. As a general rule, you should try to keep your HTML structure as simple as possible, without sacrificing the design. For example, in the code you provided, you have used Bootstrap classes to style your card container, which makes it easier to manage the layout.
  • Centering Card: Using Bootstrap classes like d-flex and justify-content-center is a good way to center your card horizontally and vertically. However, if you need to center an element in the middle of the page without using Bootstrap, you can give the parent container a fixed height and use flexbox to center the child element. For example:

  body {
    display: flex;
    justify-content: center;
    align-items: center;
  }
  
  .container {
    height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
  }
  

  • This will center the .container element both horizontally and vertically on the page.
  • Overall, I think your code looks great and you are using Bootstrap classes effectively. Keep up the good work! Happy Coding 😉.

  Marked as helpful

  1

  ---

  

  Jason Ritter•40

  @HigokianPosted over 1 year ago

  Thank you for this! I just have one question. If I'm using bootstrap, is there ever any reason to use the example you gave over bootstrap classes? It seems to me they essentially do the same thing, so I assume using bootstrap classes would typically be better considering consistency? @Shivraj-K09

  0
• 

  Sebastian•170

  @DebestaPosted over 1 year ago

  Well, You can delete div with class .card-body, because You don't refer to it anywhere, and if You want to get gap between elements in card and edge of card You can use padding on div with class .card

  1

  ---

  

  Jason Ritter•40

  @HigokianPosted over 1 year ago

  Thanks! I will mess around with this! @Debesta

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="attribution"> element with the proper semantic element <footer> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Jason Ritter•40

  @HigokianPosted over 1 year ago

  I really appreciate you explaining what landmarks are! I will likely include this in my project and re-upload it. @0xAbdulKhalid

  0