Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR Code Component Solution

@AkramGalib

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It was my first problem-solving attempt. I hope everybody will find my mistakes and advise me on overcoming them.

Community feedback

Alberto Ledesmaโ€ข 370

@ledesmx

Posted

Hi @AkramGalib ๐Ÿ‘‹

Great job on your solution!

Here are some recommendations for you:

  • Everything looks quite well except for a vertical overflow. You can remove the margin of the body to make the overflow desappear.
body {
  margin: 0;
}
  • For your next projects I suggest removing all the margin automatically added by the browser. Use the * selector to select everything and remove the margin with margin: 0;. This gives you more control over whether or not you want add margin on each element separately. You can do the same with padding, border and box-sizing. Look the example below:
* {
    margin: 0;
    padding: 0;
    border: 0;
    box-sizing: border-box;
}

I hope this helps a little.

Well done for the rest.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord