Responsive QR code component

Community feedback

• 

  Danijel Adrinek•420

  @DanijelAdrinekPosted 8 months ago

  you forgot to add the box-shadow to the design, and your design website doesnt match the design, when you work as a web dev, you will need to size down your browser, take a screenshot of your website, compare it to design, and make sure it matches, its how its done, I prefer to do it using ctrl + shift + s, and just paste-ing it in figma, you can also check the distance from one component in figma to the other by holding alt, and selecting one of the components, font-size should be the same as on the design, and css has a really helpful tool, the css variables that I recommend you learn, because on bigger projects, they are a life saver!

  Overall still one of the better projects I've seen :)

  if you want, you can also take my project as an example: https://www.frontendmentor.io/solutions/just-css-and-html-its-too-small-of-a-project-to-need-ro-add-anything-9zhphjxoE5

  I hope this helps, and if you have any further questions or need help, feel free to ask my dude :D

  Marked as helpful

  1

  ---

  

  Sayf3r•80

  @Sayf3rPosted 8 months ago

  @DanijelAdrinek thanks for your feedback it's very helpful. I didn't notice the box shadow :D . Your project looks very clean ! I'll look your code to see what I can improve

  1
• 

  Harsh Kumar Dwivedi•740

  @Harsh-Kumar-DwivediPosted 8 months ago

  Hi @Sayf3r ,

  I think you can prefer to replace <div class="main-container"> with <main> element and <p>Improve your front-end skills by building projects</p> with <h1>Improve your front-end skills by building projects</h1> element. These will improve accessibility and make your markup more semantic.

  Hope it is helpful !

  Stay Happy & Well !

  Happy Coding !

  Marked as helpful

  0

  ---

  

  Sayf3r•80

  @Sayf3rPosted 8 months ago

  @Harsh-Kumar-Dwivedi good advice I'll add this !

  0