Responsive QR Code Component

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Sayan De Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  1
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • its very small on 4k because the font width padding etc is small so increase all of them and they would fit the 4k but imo you don't have to do it

  • Always Use Semantic HTML instead of div like <main> <header> , etc for more info.

  if my solution has helped you do not forget to mark this as helpful!

  Marked as helpful

  1

  ---

  

  Sayan De•120

  @RoosterRooPosted almost 3 years ago

  @Old1337 thanks for the comment. I will be sure to incorporate those. About Semantic HTML, it's a relatively small project so I decided not to use those and go with the div but in future iterations I will change them as well.

  1
• 

  Dev Rathore•2,600

  @GitHub-dev12345Posted almost 3 years ago

  used this code to improve your design:

  In Your Card Design CSS Code Used this Property:

  margin : 20px; border-radius: 13px;

  improve your design & Good Work Keep it up ❤️👍

  0