Responsive QR Code Component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Enderzin! 👋

  Good effort on this challenge! 👍

  I notice that there's a !important in your stylesheet which I recommend trying to remove by moving the media query below the container styling. Remember, you can nest the @media query since you are using Sass.

  The only thing that the card needs to be responsive is only a max-width with either px or rem (recommended). So, there's no need for media queries.

  img tag should always alt attribute. The QR code image is the most important content of the site so I suggest adding an alternative text. Alternative text like "QR code for frontendmentor.io" would be a great alternative text because it tells the user what is the image and what is used for.

  I strongly recommend making the body element as a flex container to make the card easily in the middle of the page. This way, the container doesn't need any absolute positioning.

  That's it! Hope this helps.

  Marked as helpful

  0