Responsive QR Code Component

Community feedback

• 

  atanasov36•640

  @AtanasovCodePosted 8 months ago

  Hey, great solution. Some tips I would like to give you are centered around responsive design.

  Right now the width and height of the card are fixed which is bad practice when it comes to making sites responsive. So instead of proving a fixed height to your card, you should let the content inside determine it's height.

  So instead of doing this:

   width: 315px;
   max-width: 315px;
   height: 484px;
  

  You can instead use padding inside of the card, and apply margin and padding the the children elements inside of the card and this will make the height dynamic and based on the content inside.

  You said you struggled a bit with media queries but they are also very important when it comes to responsive design. You can think of them as breakpoints that get applied whenever a certain width is reached.

  For example you could add this bit of code to your solution that will make the card take up 90% of the screen width if the width of the screen is less than 648px:

  @media (max-width: 648px) {
      width: 90%;
      max-width: 90%;
  }
  

  Good luck and happy learning :)

  0

  ---

  

  joelani•80

  @joelaniPosted 8 months ago

  @AtanasovCode thank you so much , you just enlightened me on the fixed width and height cus i never knew i was doing something wrong

  0
• 

  Kishan Upadhyay•10

  @kishanup78910Posted 8 months ago

  dwhdwk

  0