Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @Prince-Adimado-105, some suggestions to improve you code:
-
It is best practice to have separate files for you HTML and CSS code. It helps keep things organized and make it easier to maintain.
-
There is no need for media queries on such a small component.
-
Do not use vh/vw for your values. They cause you content to break apart and distort.
Happy Coding! 👻🎃
Marked as helpful0@primadoPosted about 2 years ago@vcarames Thank you for your advice. Wow, the community here is amazing.
0 -
- @correlucasPosted about 2 years ago
👾Hi @Prince-Adimado-105, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
- Use
<main>
instead of a simple<div>
this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a<main>
block and that<div>
doesn't have any semantic meaning. - Replace the
<h2>
containing the main title with<h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level. - Add a margin of around
margin: 20px
to avoid the card touching the screen edges while it scales down. - Use relative units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
Marked as helpful0@primadoPosted about 2 years ago@correlucas Thank you very much I'll make an update soon.
0 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord