@VCarames
Posted
Hey @SamCastle16, some suggestions to improve you code:
-
For this challenge you want to use the Image Element not the Background Image Property. By using the Background Image Property screen readers users have no idea where the image is to scan.
-
Once you fix the image implementation, you'll want to include an Alt text tag with them. Inside that Alt Tag Its needs to tell screen reader users what it is and where it will take them to when they scan it.
-
Change the
width
tomax-width
in your card container to make it responsive.
Happy Coding! 👻🎃
Marked as helpful
@SamCastle16
Posted
@vcarames Hello! Thank you very much for your answer. I have already updated the project, improving the code with all your suggestions. I hope you review it again, if you find another detail or recommendation, I would appreciate it!
I implemented the QR code image inside the img tag.
I simplified the code by removing unnecessary divs and just using the basic html tags (main and footer). I also simplified the selectors in css, removing the classes to make the code cleaner.
I put the attribution outside the main element and inside the footer as you told me.
And I adjusted the responsive and it looks correct.
Thank you very much for the recommendations, they will make me grow a little more as a developer!