Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR code component

ZaiBerm 50

@ZaiBerm

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I find the media query difficult.

what is the best practice when doing a webpage? is it better to define all html element first then design it or define a single html and design it then proceed to another element?

Community feedback

Daniel 🛸 44,210

@danielmrz-dev

Posted

Hello @ZaiBerm!

Your solution looks great!

I have a couple of suggestions for improvement:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of p. The tag p is good for paragraphs, but for headings/titles, we have the tags h1 to h6. But unlike what most people think, their difference is not just about the size and weight of the text.

The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

  • Also, still about semantic HTML, replace your div.inner-div with main.inner-div.

All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

0

ZaiBerm 50

@ZaiBerm

Posted

@danielmrz-dev Thank you, I learned something new :)

1
eyu. 360

@Eyuleo

Posted

Great work, to center the div both horizontally and vertically perfectly use either

body {
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
}

or

body {
    min-height: 100vh;
    display: grid;
    place-items: center;
}

Marked as helpful

0

ZaiBerm 50

@ZaiBerm

Posted

@Eyuleo what does 100vh mean?

0
ZaiBerm 50

@ZaiBerm

Posted

@Eyuleo what does 100vh mean?

0
eyu. 360

@Eyuleo

Posted

@ZaiBerm it means the entire height of the clients device or viewport

1
ZaiBerm 50

@ZaiBerm

Posted

@Eyuleo thank you so much, i finally centered the div in the body, i cant center it because the body doesmt have a heighttttt

0
ZaiBerm 50

@ZaiBerm

Posted

@Eyuleo thank you so muchhhh!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord