Design comparison
Solution retrospective
This is my solution for QR Code Component. Any feedback or suggestion would be appreciated.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Sultan Farrel, Congratulations on completing this challenge!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
1.The HTML structure is fine and works, but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary
<div>. For this solution you wrap everything inside a single block of content using<div>or<main>(better option for accessibility) and put inside the whole content<img>/<h1>and<p>.<body> <main> <img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>2.Replace the
<h5>containing the main title with<h1>note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.3.Use relative units as
remoreminstead ofpxto improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.✌️ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord