Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR-code-component

Dana 10

@Danashu

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What specific areas of your project would you like help with?

My project doesn't look the same as the reference image: "desktop-design.jpg" and "mobile-design.jpg", is not centered on the page, it appear larger and less delicate than the reference. Can you help me fix this?

Community feedback

@TedJenkler

Posted

Hi @Danashu,

Nice project! If you want more variation in your design, consider starting with a 375px size and then adding media queries to make your desktop design a bit more different.

For this project, though, I think you’ve done a good job and would recommend moving on to a harder challenge or the next level.

I hope this was helpful!

Best, Teodor

1

Dana 10

@Danashu

Posted

Thank you@TedJenkler

1
JT M 50

@Knuckl3h3ad

Posted

Hello @Danashu,

Regarding the areas you want help with, its unlikely you'll get a perfect match each time, and in this case not the point of the challenge. You did very well and should be proud of yourself! Your solution is really close to the challenge design, so great job!

If you want a tip, for the bottom card <p> element of the class "card-body", you could increase padding-left/padding-right or font-size just a little bit to get the text to closely match the layout of the given design. Also if you're concerned about the distance between the QR code image and the text just below it, try reducing the top or bottom margining/padding on either of the 2 elements-- however yours is very close.

Something else to mention is to set the base margining/padding to 0 in the * css selector at the top of your file- if this is confusing, think of it as the same as your body or root, however its a good foundation for the rest of your styling, may help with any bugs/weird css, and looks like this: (for some reason its a dot on my comment, but it should be an asterisk).

  • { padding: 0; margin: 0; box-sizing: border-box; }

Also to note, the box sizing of "border-box" nicely keeps child elements in their respective parent element's container and doesn't allow overflow.

Anyway, I just wanted to say congrats, and may your Front-end journey go well!

I hope this was helpful!

Regards, JT M.

0

Dana 10

@Danashu

Posted

Thank you@Knuckl3h3ad

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord