Design comparison
SolutionDesign
Solution retrospective
This project allowed me to apply my HTML5 and CSS3 skills to create a functional and visually appealing web component. It also helped me gain experience in using QR codes, which can be useful in various applications such as mobile marketing and inventory management.
thanks for this project.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the element
<div class="attribution">
with semantic element<footer>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0 - @ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.
- Your accessibility report states that all page content should be contained by landmarks. So, in order to fix the accessibility issue, you need to replace
<div class="attribution">
with the<footer>
tag. - You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.
Hope I am helpful. :)
0 - Your accessibility report states that all page content should be contained by landmarks. So, in order to fix the accessibility issue, you need to replace
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord