Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Qr-code Component By Using Css Media Query

roobiwebdevβ€’ 100

@roobiwebdev

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

yes, this project have to be responsive and i did it

What challenges did you encounter, and how did you overcome them?

making the container Responsive in any screen and the problem is , to solve it i use fixed width first then in media query i used percentage

Community feedback

Dylan de Bruijnβ€’ 3,190

@DylandeBruijn

Posted

@roobiwebdev

Hiya! πŸ‘‹

Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

Things I like about your solution πŸŽ‰

  • Use of semantic HTML elements
  • Clear descriptive CSS classes

Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • Be careful with setting a fixed width and height on your elements. If the content in these elements grows beyond these restrictions you’ll run into overflow issues. Keeping the height at auto - which block elements are by default - will be fine in most cases.

  • You don’t have to wrap your image in a separate div, it’s possible to style it directly to achieve the same result. Try using an img tag instead of a background image. At the moment you have an empty img. On smaller viewports the QR code is too small and not able to be scanned.

I hope you find my feedback helpful! 🌟

Let me know if you have more questions and I'll do my best to answer them. πŸ™‹β€β™‚οΈ

Happy coding! 😎

Marked as helpful

0

roobiwebdevβ€’ 100

@roobiwebdev

Posted

@DylandeBruijn Thank you so much I did it what u said me thank you

0
MikDra1β€’ 5,990

@MikDra1

Posted

Nice one @roobiwebdev πŸ˜€,

To make your card responsive I would suggest you to give it 90% of width on smaller screens and also give it a max-width, so it will never get bigger then the size that you want it to be at the end.

If this comment we useful please mark it as helpful πŸ’—

Good job and keep going πŸ˜πŸ˜ŠπŸ˜‰

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord