@DylandeBruijn
Posted
@roobiwebdev
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution π
- Use of semantic HTML elements
- Clear descriptive CSS classes
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Be careful with setting a fixed
width
andheight
on your elements. If the content in these elements grows beyond these restrictions youβll run into overflow issues. Keeping theheight
atauto
- whichblock
elements are by default - will be fine in most cases. -
You donβt have to wrap your image in a separate
div
, itβs possible to style it directly to achieve the same result. Try using animg
tag instead of a background image. At the moment you have an emptyimg
. On smaller viewports the QR code is too small and not able to be scanned.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@roobiwebdev
Posted
@DylandeBruijn Thank you so much I did it what u said me thank you