Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR Code Component built with CSS

tchananet 170

@tchananet

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What challenges did you encounter, and how did you overcome them?

Had some issues with installing fonts, and properly sizing and placing the image

What specific areas of your project would you like help with?

Proper sizing and positioning of elements using CSS

Community feedback

N1Dovud 170

@N1Dovud

Posted

Hi there! I really liked your solution! It is almost perfect. I just have some points to help you out.

  1. You gave body height: 99vh; You needed to give min-height: 100vh; because it helps with responsiveness when the vh is too small.
  2. You applied margin 0 and padding 0 to body but as a rule of thumb, most developers use universal selector(*) for getting rid of default styling.
  3. Try to use variables defined in the root instead of putting the colors and font sizes one by one manually. This makes the code look clean, helps avoid confusion.
  4. Your container is a bit bigger than the one in the solution.
  5. Your box shadow is not spread as much in the y direction as it is in the solution. So, try fixing the y direction.
  6. try to use rems and ems more instead of px for better responsiveness.
  7. have a separate css file for styling instead of putting everything inside html file.
  8. You gave a bit too much right left padding for the paragraph and the heading. Try to lower it to match the solution. That's about it. I hope my feedback was of some use. Have a good one!
0

tchananet 170

@tchananet

Posted

Thank you @N1Dovud. This was definitely helpful. I'll work more on these angles. Thanks.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord