N1Dovud• 170
@N1Dovud
Posted
Hi there! I really liked your solution! It is almost perfect. I just have some points to help you out.
- You gave body height: 99vh; You needed to give min-height: 100vh; because it helps with responsiveness when the vh is too small.
- You applied margin 0 and padding 0 to body but as a rule of thumb, most developers use universal selector(*) for getting rid of default styling.
- Try to use variables defined in the root instead of putting the colors and font sizes one by one manually. This makes the code look clean, helps avoid confusion.
- Your container is a bit bigger than the one in the solution.
- Your box shadow is not spread as much in the y direction as it is in the solution. So, try fixing the y direction.
- try to use rems and ems more instead of px for better responsiveness.
- have a separate css file for styling instead of putting everything inside html file.
- You gave a bit too much right left padding for the paragraph and the heading. Try to lower it to match the solution. That's about it. I hope my feedback was of some use. Have a good one!
0
tchananet• 170
@tchananet
Posted
Thank you @N1Dovud. This was definitely helpful. I'll work more on these angles. Thanks.
1