Responsive QR Code Component

Community feedback

• 

  Paweł•1,030

  @Pawel-GnatPosted over 2 years ago

  Hi, you forgot to add google fonts in your html and try not to use <br> to wrap your text, but set some width and height to your div and nest it there. Add some margin-bottom to your gray text also. Btw. add <main> content to repair access issues and please don't use inline styling if you have css sheet to do this.

  Good luck!

  Marked as helpful

  1

  ---

  

  Johna•10

  @Johna-123Posted over 2 years ago

  @Pawel-Gnat, thanks for the feedback, I'll fix it up soon.

  0
• 

  P

  Kent O'Sullivan•1,870

  @12KentosPosted over 2 years ago

  Hey @Johna-123,

  Great job on completing the challenge, I think you did a really good job and it looks great! :)

  I would second what @Pawel-Gnat said about the in-line styles it's really bad practice, makes code messy and difficult to maintain.

  Keep up the great work though, looking forward to seeing your completed second challenge! :)

  Marked as helpful

  0

  ---

  

  Johna•10

  @Johna-123Posted over 2 years ago

  Thanks @12Kentos and @Pawel-Gnat for pointing out that in-line styles are bad. 😅

  1
• 

  Johna•10

  @Johna-123Posted over 2 years ago

  I'm not sure what happened to the font, but if you click preview site, it have the normal font. 🙂

  0