Responsive QR Code Component

Community feedback

• 

  Danijel Adrinek•420

  @DanijelAdrinekPosted 7 months ago

  Hey Rohit, I liked your project and decided to take a look at it for a bit, and I found some things I think you can improve on.

  1. You forgot to add the box-shadow

  2. The height on your body would be better if it was in % instead of vh, but remember to add height of 100% to the html tag too for it to work (I got scolded for this on my first web dev job too)

  3. You dont need to make your card inside the main tag, you can just replace the div with the class of container with a main tag, all the main content is in it anyway

  4. Class of content could have a more common class name of text-container, thats more like the standard

  5. Use CSS variables, they are a powerful tool to help make your code more readable and easy to manipulate

  6. Even tho the solution you provided is awesome, and close to the design, us frontend developers need to be really precise, thats why, if you want, I have made a blog post about solving this solution in pixel-perfect manner, the way I was taught on my job, so if you are interested in that, here is the post, feel free to read trough it:

  https://dev.to/danijeladrinek/frontend-mentor-qr-code-challenge-4g9h

  I hope these tips help you become a better web developer, and help you on your journey towards getting this amazing job! 🚀

  if you have any more questions feel free to let me know, have an amazing day, and happy coding :)

  Marked as helpful

  0

  ---

  

  Rohit Dubey•335

  @rohitdubey1352Posted 7 months ago

  Thanks, @DanijelAdrinek For your feedback, I will surely make some changes accordingly.

  1
• 

  Sourabh dhiman•20

  @sourabhdhiman1262Posted 7 months ago

  na

  0